Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for 404 bug, and removed labelmap breaking code #3549

Merged
merged 1 commit into from
May 18, 2024

Conversation

JeremyFreiburger
Copy link
Collaborator

@JeremyFreiburger JeremyFreiburger commented May 15, 2024

Resolves #3512

I removed the modal clean up code in the labelmap file and I added a check when resetting the panorama in the gsv label view file. When I removed the _resetModal call in the showLabel method the code works fine for all four of the locations(labelMap, admin dashboard, contributions, adminmap). However, I found a bug on the contributions tab which occurs when a gsv is deleted by google.

The steps to reproduce this bug(with screenshots below), is to go to the admin contributions tab and go to the very last page and click on a gsv that is deleted(NoCurbRamp severity 3 on the last page), then click on another gsv that is not deleted(any of the top curb ramps) and these should log a 404 error to the console. After I click on a few other gsv's that are not deleted the issue fixes itself. I solved this issue by calling _resetModal everytime a user clicks on a deleted gsv. If deleted labels are removed the contributions tab, this issue will also fix itself.

Before/After screenshots (if applicable)
Testing instructions
Screen Shot 2024-05-15 at 2 22 41 PM Screen Shot 2024-05-15 at 2 22 11 PM
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.
  • I've updated any logging. Clicks, keyboard presses, and other user interactions should be logged. If you're not sure how (or if you need to update the logging), ask Mikey. Then make sure the documentation on this wiki page is up to date for the logs you added/updated.
  • I've tested on mobile (only needed for validation page).

@misaugstad
Copy link
Member

@JeremyFreiburger okay so this PR now supersedes #3542 and is still meant as a fix for #3512?

And can you confirm if/when you've tested in the four places mentioned here?

@JeremyFreiburger
Copy link
Collaborator Author

Yes, this pr fixes #3512, and i've tested it in the 4 places.

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this will still have the same problem if you click on a bunch of expired images... But I think that that is uncommon enough that you've done what really needs to be done. Hopefully we can have the modal reset in a more robust way in the future, but this will do for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LabelMap breaks if you look at too many labels
3 participants