Added check for 404 bug, and removed labelmap breaking code #3549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3512
I removed the modal clean up code in the labelmap file and I added a check when resetting the panorama in the gsv label view file. When I removed the _resetModal call in the showLabel method the code works fine for all four of the locations(labelMap, admin dashboard, contributions, adminmap). However, I found a bug on the contributions tab which occurs when a gsv is deleted by google.
The steps to reproduce this bug(with screenshots below), is to go to the admin contributions tab and go to the very last page and click on a gsv that is deleted(NoCurbRamp severity 3 on the last page), then click on another gsv that is not deleted(any of the top curb ramps) and these should log a 404 error to the console. After I click on a few other gsv's that are not deleted the issue fixes itself. I solved this issue by calling _resetModal everytime a user clicks on a deleted gsv. If deleted labels are removed the contributions tab, this issue will also fix itself.
Before/After screenshots (if applicable)
Testing instructions
Things to check before submitting the PR