Skip to content
This repository was archived by the owner on Nov 26, 2024. It is now read-only.

From cesium1.70.1 #7

Closed
wants to merge 1,111 commits into from
Closed

From cesium1.70.1 #7

wants to merge 1,111 commits into from

Conversation

katSchmid
Copy link

updating to cesium 1.70.1, I am not quite sure if we have any custom code in the package

lilleyse and others added 30 commits May 11, 2020 23:01
Add space to JSDoc attributes
Fix problem switching from Uint16 to Uint32 indices for outlining.
Added frustumSplits option to DebugCameraPrimitive
Simplify skinning to always expect VEC4 joint/weight accessors.
I was modifying gulpfile in another branch and realized formatting was
not set up correctly.
fredj and others added 23 commits June 8, 2020 15:12
…; Adding tests for Transforms.rotationMatrixFromPositionVelocity
We were including all Cesium directories in the TypeScript smokescreen
configuration. This meant that multiple Cesium.d.ts files were included
if you did a full build and then ran `build-ts` afterwards. This updates
the config used by the smokescreen to only include Source.
Exposing Transforms.rotationMatrixFromPositionVelocity
Add some missing readonly documentation tags
Only include Source folder in TypeScript smokescreen tests.
Expose buildModuleUrl as part of the Cesium API
None of the `XXXGeometry` classes are actually `Geometry` instances. They
are instead utility classes that create geometries via their
`createGeometry` implementation. `GeometryInstance` can take either "type"
but since JS doesn't have types we never really defined what the "utility"
type is, so the TypeScript definition for `GeometryInstance` specifies that
currently only specifies `Geometry`. This means that this valid JS code
is a compiler error in TypeScript

```
const geometryInstance = new GeometryInstance({
  geometry: new PolylineGeometry({
    positions: [],
  }),
});
```

To fix this, I introduced a `GeometryFactory` base class like we have
elsewhere in the code and changed `GeometryInstance` to take either type.
This is the only place where we actually base "non-geometry Geometry" in
the API.

Happy to consider other names, like `GeometryCreator` if we don't like
factory for some reason, but I want to get this in sooner rather than
later for 1.70.1 fixes.

Also fixed an issue with tsconfig.json I introduced in my last change
which was failing to actually catch TS compile errors because it wasn't
including the Cesium.d.ts.
Fix geometry creation in TypeScript
@katSchmid katSchmid requested a review from chris-cooper June 22, 2020 07:46
@katSchmid
Copy link
Author

#8

@katSchmid katSchmid closed this Jun 24, 2020
@katSchmid katSchmid deleted the fromCesium1.70.1 branch February 3, 2022 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.