Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ban system conversion issue with MySQL #2269

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Conversation

hakusaro
Copy link
Member

DeathCradle spotted a typo in the ban converter and identified that the
issue is likely because we used table_name in some, but not all, of the
conversion SQL.

@hakusaro hakusaro requested a review from SignatureBeef April 11, 2021 07:03
@hakusaro hakusaro enabled auto-merge April 11, 2021 07:03
SignatureBeef
SignatureBeef previously approved these changes Apr 11, 2021
Copy link
Member

@SignatureBeef SignatureBeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this is exactly what i would have committed.

@hakusaro hakusaro requested a review from QuiCM April 11, 2021 07:10
DeathCradle spotted a typo in the ban converter and identified that the
issue is likely because we used table_name in some, but not all, of the
conversion SQL.

Co-authored-by: DeathCradle <rt.luke.s@gmail.com>
@SignatureBeef
Copy link
Member

IMO This should not be merged until PR #2271 is reviewed/merged.

@hakusaro hakusaro disabled auto-merge April 12, 2021 05:06
@hakusaro hakusaro merged commit 070787e into general-devel Apr 12, 2021
@hakusaro hakusaro deleted the h/fix-typo branch April 12, 2021 05:06
@hakusaro hakusaro restored the h/fix-typo branch April 12, 2021 05:07
@hakusaro hakusaro mentioned this pull request Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants