Fix ban system #2271
Merged
Fix ban system #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now allows MonoDevelop to compile without receiving error while starting a build: System.IO.FileLoadException: The assembly name is invalid
Tested with existing bans in both sqlite & mysql environments. This is in addition to the syntax fix from earlier.
|
This looks fine to me |
QuiCM
approved these changes
Apr 11, 2021
|
oml |
|
I merged #2269 first because I didn't realize that the base ref of this PR was #2269's branch. Oops. I can't test the ban conversion process because I don't have a MySQL server configured and I don't have an old ban database in either format, so I'm waiting for someone to test the conversion process. |
Pointed out thanks to this discussion: #2268 (comment)
|
Can confirm the conversion works on MySQL 8.0.23 |
|
Also seems to work with SQLite |
hakusaro
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the migration/conversion process in the ban manager for both sqlite & mysql; and on the side it allows TShock to build on OSX/MonoDevelop (assembly name fix, not a big deal).
My end i have confirmed that the server now boots for both database implementations (on OSX).
I have not yet tested to make sure the ban system actually works in game etc.