Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddingPowerSupport_CI/Testing #364

Merged
merged 2 commits into from
Dec 8, 2020
Merged

AddingPowerSupport_CI/Testing #364

merged 2 commits into from
Dec 8, 2020

Conversation

santosh653
Copy link
Contributor

Adding power support & updating the go versions to >=1.13 as lower versions are not supported.,

Adding power support ppc64le with Continues Integration/testing so that code remains architecture independent.

This is part of the Ubuntu distribution for ppc64le. This helps us simplify testing later when distributions are re-building and re-releasing. For more info tag @gerrith3.

The build is successful on both arch: amd64/ppc64le, please find the Travis Link below.
https://travis-ci.com/github/santosh653/goquery

Please let me know if you need any further details,

Thank You!!

Adding power support & updating the go versions to >=1.13 as lower versions are not supported.,
@mna
Copy link
Member

mna commented Dec 7, 2020

Hello @gerrith3 ,

I have no problem adding test support for other architectures, but not at the expense of dropping tests on older versions of Go. There's surely a way to run a different set of Go versions for each architecture?

Martin

@gerrith3
Copy link

gerrith3 commented Dec 8, 2020

@mna hey you can definitely customize the .travis.yml to run different things on different architectures. @santosh653 should be able to update the .travis.yml. Having said that, a bunch of those go versions should be pretty completely out of date. The only versions I would really trust to be solid on ppc64le are 13/14/15 and later - earlier may work. But you should be able to run any of the old versions on Intel if you want to. Personally, I don't see a lot of value in that but you know your project better than we do. And trimming the versions a little is a good way to save yourself some CI minutes, although that doesn't really matter - if you run out, ask travis for more.

@mna
Copy link
Member

mna commented Dec 8, 2020

Yeah let's not arbitrarily drop support for any old version on amd64, at least as long as travis or other CI let's us do so. Feel free to use just the versions you need on ppc.

Excluding unsupported versions for Power., ie go <=1.12.x
@santosh653
Copy link
Contributor Author

@mna I have excluded what is not supported on Power ie go<=1.12.x & I am running the code for all the go versions for amd64.,
I hope this change in the code answers & addresses your query.,

The Travis Build is also successful with the new set of changes.
Looping @gerrith3

@mna mna merged commit 70a02e5 into PuerkitoBio:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants