Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/support portfolio insights for ad groups #338

Conversation

ThomasGranheim
Copy link
Contributor

@ThomasGranheim ThomasGranheim commented Nov 16, 2020

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check your code additions will fail linting checks
  • Remember: Add PR description to Changelog with the ID that matches this PR

Description

AD groups added to SP group will now also get portfolio insight.
Fix to bug: #332

How to test

  • 1. Add AD group to portfolio insight SP group
  • 2. Make sure users in AD group get portfolio insight
  • 3. Also, test that users added directly to SP group get portfolio insight

💔Thank you!

@Remi749 Remi749 added this to the 1.2.4 milestone Nov 17, 2020
@olemp
Copy link
Collaborator

olemp commented Nov 18, 2020

@ThomasGranheim Is #339 related to this? Does it need a separate PR, or can it just be added to this? Also, can you resolve the conflicts <3

Copy link
Collaborator

@olemp olemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix conflicts (update from dev), and update CHANGELOG (same change as in separate PR)

@ThomasGranheim
Copy link
Contributor Author

Does it look OK now? Fetched from the dev branch and merged it into new feature branch. Also added the CHANGELOG commit to this PR.

Copy link
Collaborator

@olemp olemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@olemp olemp merged commit 0b59a03 into Puzzlepart:dev Nov 20, 2020
@olemp olemp linked an issue Nov 20, 2020 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Prosjektinnsyn does not work for users added as part of AD-group
3 participants