Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Prosjektinnsyn does not work for users added as part of AD-group #332

Closed
2 tasks done
tarjeieo opened this issue Nov 12, 2020 · 2 comments · Fixed by #338
Closed
2 tasks done

Bug: Prosjektinnsyn does not work for users added as part of AD-group #332

tarjeieo opened this issue Nov 12, 2020 · 2 comments · Fixed by #338
Labels
bug Something isn't working
Milestone
1.2.4

Comments

@tarjeieo
Copy link
Member

tarjeieo commented Nov 12, 2020 •
edited by pzljanb
Loading

Describe the bug
The new Prosjektinnsyn SP group should give access to see the whole portfolio. Looks like this is not working when an AD group is added to the SP group.

To Reproduce
Steps to reproduce the behavior:

  • 1. Add an AD group to Prosjektinnsyn SP group
  • 2. Check that the user you're testing with does not see all projects

Expected behavior
The users should see all projects when they are added to Prosjektinnsyn, even through AD-groups.
@tarjeieo tarjeieo added the bug Something isn't working label Nov 12, 2020
@tarjeieo
Copy link
Member Author

Might need to do something in the lines of https://stackoverflow.com/questions/43654587/how-to-check-if-user-belongs-to-a-sharepoint-ad-group-or-not-using-rest-javascri

ThomasGranheim added a commit to ThomasGranheim/prosjektportalen365 that referenced this issue Nov 15, 2020
@ThomasGranheim
Puzzlepart#332 - Support adding AD groups to SP groups for prosjektin…
beebaf2 
…nsyn
ThomasGranheim added a commit to ThomasGranheim/prosjektportalen365 that referenced this issue Nov 16, 2020
@ThomasGranheim
Puzzlepart#332 refactor and use filter query to fetch group by title
656f7ea
ThomasGranheim added a commit to ThomasGranheim/prosjektportalen365 that referenced this issue Nov 16, 2020
@ThomasGranheim
Puzzlepart#332 remove redundant imports
f685877
@ThomasGranheim ThomasGranheim mentioned this issue Nov 16, 2020
Merged
8 tasks
ThomasGranheim added a commit to ThomasGranheim/prosjektportalen365 that referenced this issue Nov 18, 2020
@ThomasGranheim
Puzzlepart#332 Update to CHANGELOG.md for issue
7bd0570
@olemp olemp linked a pull request Nov 20, 2020 that will close this issue
Enhancement/support portfolio insights for ad groups #338
Merged
8 tasks
@olemp
Copy link
Collaborator

olemp commented Nov 20, 2020

Solved by #338

@olemp olemp closed this as completed Nov 20, 2020
@Remi749 Remi749 mentioned this issue Nov 23, 2020
Closed
10 tasks
@Remi749 Remi749 added this to the 1.2.4 milestone Nov 23, 2020
This was referenced Nov 26, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.4
Development

Successfully merging a pull request may close this issue.

Enhancement/support portfolio insights for ad groups ThomasGranheim/prosjektportalen365
3 participants
@tarjeieo @olemp @Remi749