Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #352 #354

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Fix for #352 #354

merged 1 commit into from
Nov 26, 2020

Conversation

olemp
Copy link
Collaborator

@olemp olemp commented Nov 26, 2020

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check your code additions will fail linting checks
  • Remember: Add PR description to Changelog with the ID that matches this PR

Description

In order for #332 to work OnlyAllowMembersViewMembership needs to be set to true for the Porteføljeinnsyn group in our template.

How to test

See #352

Relevant issues (if applicable)

Closes #352
#332
#243

@olemp olemp merged commit d841777 into dev Nov 26, 2020
@olemp olemp deleted the issue/352 branch November 26, 2020 15:12
@olemp olemp mentioned this pull request Nov 26, 2020
Closed
@Remi749 Remi749 mentioned this pull request Nov 27, 2020
Closed
10 tasks
@Remi749 Remi749 added this to the 1.2.4 milestone Nov 27, 2020
@pzljanb
Copy link
Contributor

pzljanb commented Nov 27, 2020

Tested OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@olemp olemp

Labels
None yet
Projects
None yet
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.

Portfolio content not limited to access level
3 participants
@olemp @pzljanb @Remi749