Read-only access for project list webpart #498

Rundez · 2021-08-09T10:27:37Z

Your checklist for this pull request

Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
Check the commit's or even all commits' message
Check if your code additions will fail linting checks
Remember: Add PR description to CHANGELOG with the ID that matches this PR

Description

Added the possibility to see all projects when the user is in the "Porteføljeinnsyn" group. This can be toggled on and off in the projectlist web part. If it is toggled on, the user(s) in "Porteføljeinnsyn" will notice additional buttons appear right of the search bar. These buttons will change the current view, toggling between seeing all projects, and projects that the user is a member of.

How to test

Add a user to the "Porteføljeinnsyn" group.
Navigate to the project list property pane and turn on "Vis alle prosjekter"
Toggle the buttons that appear. No deleted projects should appear, and projects you are not a member of should not ble clickable.

Disclaimer:
Deleted projects will be shown if "All projects" is selected. A solution is will be delivered in a separate PR.

Relevant issues (if applicable)

closes #443

💔Thank you!

…ect list.

…x and toggle + conditional rendering

olemp · 2021-08-09T10:57:46Z

@Rundez Have you installed this somewhere for testing?

Rundez · 2021-08-09T10:59:39Z

@olemp I have only served it in my own dev environment.

tarjeieo · 2021-08-17T09:19:15Z

@Rundez can we setup a separate instance of pp365 in our demo tenant and share for testing? Seems like something that should be thoroughly tested

Rundez · 2021-08-17T12:51:05Z

@tarjeieo I am setting one up.

Rundez · 2021-08-18T08:29:20Z

Created a PP instance at this site.

Rundez · 2021-08-18T09:08:13Z

Two projects are created. The user Hugo First have been added in the "Porteføljeinnsyn" group, and will then have the ability to see projects he's not member of.

@tarjeieo
@olemp

* Added opacity and alert message to ReadOnly projects (Frontpage) * Removed alert message and added tooltip and cursor to ReadOnly projects * Using title html attribute Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

olemp

Most looks good, but I don't understand the logic 100%.

What does the "Vis alle prosjekter" toggle do? And how is it related to "Flisevisning"?

Is it the toggle in web part properties that decides whether to show the "Mine prosjekter/Alle prosjekter" links? I don't find that so intuitive. Do we need a webpart property to toggle this option?

Also, we need to change the placeholder based on what "view" is selected.

Rundez · 2021-09-02T14:20:54Z

Ah yes - it is not related to "Flisevisning" actually. As you said, it decides wether the links are displayed. It might be unnecessary, or it could be moved to another submenu in project properties.

I agree with the placeholders. As I removed the function that checks for deleted projects the problem occured. It did only occur on projects in the project list that actually is deleted? I will create a fix.

Rundez · 2021-10-14T07:21:44Z

Having a little isuse. While testing at https://puzzlepart.sharepoint.com/sites/pp365.
Seems it seems like all projects, even those who already got a project logo is overwritten by the placeholder. Probably a minor thing which will be solved pretty fast.

olemp · 2021-10-14T09:03:20Z

SharePointFramework/PortfolioWebParts/src/components/ProjectList/index.tsx

+      loading: true,
+      searchTerm: '',
+      showAsTiles: props.showAsTiles,
+      onlyAccessProjects: true


Is onlyAccessProjects used like a prop @Rundez? Seems like it's hardcoded to true? Don't see the point of this state variable, but I might be missing something.

It's meant to toggle between what projects are shown. I realize it might need a namechange for readability...

@Rundez My Projects will only show projects the user is a member of any way, so I don't see the need for this property?

It only does so because of the filtering done in _filterProjects though. As seen below:
(just did a namechange to displayAllProjects)

How is readOnly set, and where?

It is set in the constructor of the ProjectListModel.

Used in the _mapProjects function in data/index.tsx

olemp · 2021-10-14T09:12:01Z

SharePointFramework/PortfolioWebParts/src/components/ProjectList/index.tsx

+      )
+
+      if (!this.state.onlyAccessProjects)
+        projects = projects.filter((project) => project.readOnly === false)


@Rundez Where is readOnly property set?

olemp

See comments above.

olemp · 2021-10-14T11:16:29Z

Having a little isuse. While testing at https://puzzlepart.sharepoint.com/sites/pp365. Seems it seems like all projects, even those who already got a project logo is overwritten by the placeholder. Probably a minor thing which will be solved pretty fast.

What is happening exactly? Seems to work here.

Rundez · 2021-10-14T11:18:26Z

What is happening exactly? Seems to work here.

If it's over 20 projects, the project logo fetch is batched. It seems like that creates the issue. Not completely sure why it's happening though.

olemp · 2021-10-14T11:35:29Z

What is happening exactly? Seems to work here.

If it's over 20 projects, the project logo fetch is batched. It seems like that creates the issue. Not completely sure why it's happening though.

This might solve the issue.

Rundez · 2021-10-14T11:45:58Z

What is happening exactly? Seems to work here.

If it's over 20 projects, the project logo fetch is batched. It seems like that creates the issue. Not completely sure why it's happening though.

This might solve the issue.

Works like charm!

Rundez and others added 14 commits July 22, 2021 14:14

Users in "Porteføljeinnsikt" can now display all projects in the proj…

051aa31

…ect list.

Added toggle to make each user have the choice to see all projects

346e14e

Moved filter function to filter method...

f4de508

Added filtration to remove deleted projects in portfolio view

de0efa5

Checks if the user is in portfolio management group

9ad673a

Added pivot selector for project display, updated styles for searchbo…

3e7413e

…x and toggle + conditional rendering

Added filtering to remove all deleted project from portfolio insights

21c48f4

Formatting

fbb203b

Fixed warnings and errors

f539674

Added find instead of filter for readability and performance

00d267e

Merge branch 'dev' into feature/portfolioReadOnly

33a5d18

Added delete from the project list itself instead of filtering

cb441df

Split PR 494.

ee35c1e

No need for function to be async

33c9601

Rundez requested a review from olemp August 9, 2021 10:27

Rundez self-assigned this Aug 9, 2021

Fixed linting errors and warnings

16c64ef

This was linked to issues Sep 2, 2021

Dynamic risk matrix #433

Closed

Read-only access to portfolio frontpage project view #443

Closed

olemp removed a link to an issue Sep 2, 2021

Dynamic risk matrix #433

Closed

olemp requested changes Sep 2, 2021

View reviewed changes

Merge branch 'dev' into feature/#433

43e5dae

olemp added 2 commits October 14, 2021 10:44

Merge branch 'dev' into feature/#433

b8268dd

Removed unused prop showAllProjects from IProjectListProps

84c9aa5

olemp reviewed Oct 14, 2021

View reviewed changes

olemp added 3 commits October 14, 2021 11:05

Ran lint:fix

3f4473e

jsdoc format

74ee4b3

SpinnerType => SpinnerSize

efa8340

olemp changed the title ~~Read-only access to portfolio~~ Read-only access for project list webpart Oct 14, 2021

olemp reviewed Oct 14, 2021

View reviewed changes

olemp requested changes Oct 14, 2021

View reviewed changes

olemp added 2 commits October 14, 2021 12:08

SharePointFramework/.vscode/settings.json

0d4c147

Added **/dist to files.exclude

1d8097c

olemp marked this pull request as draft October 14, 2021 10:18

olemp added 3 commits October 14, 2021 12:45

readOnly => userIsMember (for readability)

2f2928b

onlyAccessProjects => selectedView

1c7acf7

Styling

0e50898

placeholderImage fix

6757858

Merge branch 'dev' into feature/#433

cdf1809

olemp marked this pull request as ready for review October 14, 2021 12:00

olemp added 4 commits October 14, 2021 14:03

Removed ProjectListModel.exists

d9ddfdb

Linting

9f14519

jsdoc updates

195d0cc

Merge branch 'dev' into feature/#433

50dd700

olemp merged commit 100d7d6 into dev Oct 14, 2021

olemp deleted the feature/#433 branch October 14, 2021 12:22

pzljanb mentioned this pull request Oct 15, 2021

Test og release av v1.3.0 #534

Closed

26 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Read-only access for project list webpart #498

Read-only access for project list webpart #498

Rundez commented Aug 9, 2021 •

edited

Loading

olemp commented Aug 9, 2021

Rundez commented Aug 9, 2021

tarjeieo commented Aug 17, 2021

Rundez commented Aug 17, 2021

Rundez commented Aug 18, 2021

Rundez commented Aug 18, 2021 •

edited

Loading

olemp left a comment

Rundez commented Sep 2, 2021 •

edited

Loading

Rundez commented Oct 14, 2021 •

edited

Loading

olemp Oct 14, 2021

Rundez Oct 14, 2021

olemp Oct 14, 2021

Rundez Oct 14, 2021

olemp Oct 14, 2021

Rundez Oct 14, 2021

olemp Oct 14, 2021

olemp left a comment

olemp commented Oct 14, 2021

Rundez commented Oct 14, 2021 •

edited

Loading

olemp commented Oct 14, 2021

Rundez commented Oct 14, 2021 •

edited

Loading

Read-only access for project list webpart #498

Read-only access for project list webpart #498

Conversation

Rundez commented Aug 9, 2021 • edited Loading

Your checklist for this pull request

Description

How to test

Relevant issues (if applicable)

olemp commented Aug 9, 2021

Rundez commented Aug 9, 2021

tarjeieo commented Aug 17, 2021

Rundez commented Aug 17, 2021

Rundez commented Aug 18, 2021

Rundez commented Aug 18, 2021 • edited Loading

olemp left a comment

Choose a reason for hiding this comment

Rundez commented Sep 2, 2021 • edited Loading

Rundez commented Oct 14, 2021 • edited Loading

olemp Oct 14, 2021

Choose a reason for hiding this comment

Rundez Oct 14, 2021

Choose a reason for hiding this comment

olemp Oct 14, 2021

Choose a reason for hiding this comment

Rundez Oct 14, 2021

Choose a reason for hiding this comment

olemp Oct 14, 2021

Choose a reason for hiding this comment

Rundez Oct 14, 2021

Choose a reason for hiding this comment

olemp Oct 14, 2021

Choose a reason for hiding this comment

olemp left a comment

Choose a reason for hiding this comment

olemp commented Oct 14, 2021

Rundez commented Oct 14, 2021 • edited Loading

olemp commented Oct 14, 2021

Rundez commented Oct 14, 2021 • edited Loading

Rundez commented Aug 9, 2021 •

edited

Loading

Rundez commented Aug 18, 2021 •

edited

Loading

Rundez commented Sep 2, 2021 •

edited

Loading

Rundez commented Oct 14, 2021 •

edited

Loading

Rundez commented Oct 14, 2021 •

edited

Loading

Rundez commented Oct 14, 2021 •

edited

Loading