-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake8 5.0 seemingly deprecated .flake8 config without writing it in the changelog #1630
Labels
Comments
3 tasks
show your configs? they should both work and we test that they both work |
ah, you have flake8 config in both files. the first one wins and the first one was changed (this is called out in the changelog under fixes, that the config containing you were in undefined behavior before with config in two files |
Thanks for the help! We understand what was going on now :) |
wmfgerrit
pushed a commit
to wikimedia/mediawiki-tools-release
that referenced
this issue
Aug 1, 2022
* Merged all flake8 config to a single file, as loading it from multiple places is no longer supported (PyCQA/flake8#1630). * Cleaned up make-release tests to pass updated linter standards. Change-Id: Iae927745677cb69f53f682fc9075e6f51e279120
wmfgerrit
pushed a commit
to wikimedia/homer
that referenced
this issue
Aug 9, 2022
flake8 no longer supports reading config from both tox.ini and setup.cfg https: //github.com/PyCQA/flake8/issues/1630 Change-Id: I479a2f75866ea5e58f547647665113ceabcec1ad
wmfgerrit
pushed a commit
to wikimedia/operations-software-pywmflib
that referenced
this issue
Aug 30, 2022
flake8 no longer supports reading config from both tox.ini and setup.cfg https: //github.com/PyCQA/flake8/issues/1630 Change-Id: I4cc1e682faeabcc691ea8dc621b98124a98c70b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
how did you install flake8?
pip install flake8
unmodified output of
flake8 --bug-report
describe the problem
After upgrading to flake8 5.0, it now silently ignores my .flake8 file. I had not expected this as it is not described in the changelog. Everything works fine once the flake8 config is moved to setup.cfg.
The text was updated successfully, but these errors were encountered: