-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #1223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to other contributors:
LGTM except for several mypy
errors that need to be fixed: https://results.pre-commit.ci/run/github/17939040/1677540245.VvURZtjgSmyCCC9kJo-7Ww
Additionally, it looks like flake8
checks for a line length of 80, while our line limit should be 100 characters.
I can't address this right away, please assign yourself or leave a message if you are working on it.
3e733eb
to
15353ee
Compare
46ce916
to
d4151bc
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1223 +/- ##
===========================================
+ Coverage 85.24% 85.60% +0.36%
===========================================
Files 38 38
Lines 5008 5009 +1
===========================================
+ Hits 4269 4288 +19
+ Misses 739 721 -18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
9afa80b
to
b6285e9
Compare
I just had a look at what went wrong here with
and one has to instead pass it in manually:
|
After looking into this a bit more, I found that this problem was introduced in PyCQA/flake8@65c8937 and that the previous commit PyCQA/flake8@00ca630 actually works. This can be tested by putting the commit hashes into the I will raise an issue with the flake8 project if someone can confirm this. |
updates: - [github.com/psf/black: 22.6.0 → 23.3.0](psf/black@22.6.0...23.3.0) - [github.com/pre-commit/mirrors-mypy: v0.961 → v1.2.0](pre-commit/mirrors-mypy@v0.961...v1.2.0) - [github.com/pycqa/flake8: 4.0.1 → 6.0.0](PyCQA/flake8@4.0.1...6.0.0)
for more information, see https://pre-commit.ci
a6d6cfe
to
63dc0cc
Compare
I forgot to post the reason why this failed and what I fixed: PyCQA/flake8#1630 |
updates: