-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake8 and importlib_metadata
5.0 support
#1701
Comments
importlib_metadata
importlib_metadata
5.0 support
please actually fill out the issue template and make sure to include your version info (hint hint) |
@asottile Sorry about that, I had it in edit in another tab and added it in. |
you're 2 major versions of flake8 out of date |
Good point. I came here through python/importlib_metadata#406, and use poetry, and it has a dependency of Will go back to them. |
See: PyCQA/flake8#1701 This hopefully gets resolved in flake8 and can be re-enabled.
flake8 not compatible with 22Oct1 release of importlib_metadata v5 see PyCQA/flake8#1701 set importlib_metadata to 4.13.0
Just wanted to share my mistake to maybe save someone else some time. - repo: https://gitlab.com/pycqa/flake8
+ repo: https://github.com/PyCQA/flake8 |
Use latest versions of all the hooks which we include. flake8 has moved to GitHub which means we tracked a stale repo until now [1]. Update to the correct upstream. [1]: PyCQA/flake8#1701
Fixes support for importlib_metadata 5.0.0, PyCQA/flake8#1701
This was causing problems in CI due to this issue: PyCQA/flake8#1701
Have to update to Python 3.8+ so we can get flake8 v6 because v5 has this issue (on Python 3.7): PyCQA/flake8#1701
…833) Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` ```diff repos: - repo: https://github.com/pycqa/flake8 - rev: 4.0.1 + rev: 7.0.0 hooks: - id: flake8 ``` As discussed at: * PyCQA/flake8#1701 Pull Request resolved: #833 Test Plan: For test failures on Python < 3.10 see: * #832 Reviewed By: grievejia Differential Revision: D56535569 Pulled By: migeed-z fbshipit-source-id: 576cccafeca06e6ebe1290bcd115c53e4a07fbc2
flake8: 3.9.2
importlib-metadata: 5.0.0
how did you install flake8?
$ poetry install
unmodified output of
flake8 --bug-report
describe the problem
what I expected to happen
Normal usage
sample code
commands ran
The text was updated successfully, but these errors were encountered: