flake8 dependency fix for python3.7. #65
Conversation
| @@ -16,6 +16,7 @@ def get_requirements(): | |||
| "flake8==3.9.2", | |||
| "isort==5.9.2", | |||
| "pytest>=6.2.4", | |||
| "importlib-metadata>=1.1.0,<4.3;python_version<'3.8'", | |||
There was a problem hiding this comment.
Is python_version for the supported python version or has a different meaning? I am asking because we have been supporting till 3.7, 3.8 and 3.9
There was a problem hiding this comment.
It's a condition for managing dependencies, "it solely says if python is < 3.8, then install this.", it does not make trapper bound to python < 3.8.
On another perspective I thought for a second why not setuptools can infer this as another package?; this is a good point, I thought it was supported (for conditioning on python versions) and I got this directly from flake8, but they included this on setup.cfg rather than on requirements.txt or setup.py.
When I searched for that package on pypi, I actually founded a package python_version, so including this on setup.py instead of setup.cfg might install that redundant (?) package I think.
Update: It turns out that python_version is a reserved marker for setuptools, so there's no problem. Also, it's advised for another related issue. All good so far 🙂
devrimcavusoglu
requested review from
cemilcengiz,
SecilOzkSen and
Sophylax
and removed request for
SecilOzkSen and
cemilcengiz
Related issue PyCQA/flake8#1701