Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheel file generated with maturin 1.7.6 doesn't check with twine 5.1.1 #2335

Open
1 of 2 tasks
konn opened this issue Nov 29, 2024 · 1 comment
Open
1 of 2 tasks

Wheel file generated with maturin 1.7.6 doesn't check with twine 5.1.1 #2335

konn opened this issue Nov 29, 2024 · 1 comment
Labels
upstream Upstream issue wontfix This will not be worked on

Comments

@konn
Copy link

konn commented Nov 29, 2024

Bug Description

With maturin 1.7.6, the wheel file generated by pip wheel won't be validated with twine check with twine >= 5.1.1.
The root cause seems that maturin 1.7.6 switched to metadata version to 2.4, which is not yet supported by twine 5.1.1 - so this might have to be addressed on twine side and it seems that there is the PR for this.

So,the reason I opened this issue is not to request fix this issue on maturin side- rather, I intend this issue to be a note for anyone else who encountered this situation. If this is inappropriate, please feel free to close this.

Your maturin version (maturin --version)

1.7.6

Your Python version (python -V)

3.9.20

Your pip version (pip -V)

pip 23.0.1

What bindings you're using

pyo3

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

  1. Build PyO3 project with maturin 1.7.6
  2. Bundle it with pip wheel
  3. Feed it to twine@5.1.1 check, then it complains as follows:
Checking dist/my-package-cp39-cp39-macosx_11_0_arm64.whl: ERROR    InvalidDistribution: Metadata is missing required fields: Name, Version.
         Make sure the distribution includes the files where those fields are specified, and is using a supported Metadata-Version: 1.0, 1.1, 1.2, 2.0,
         2.1, 2.2, 2.3.
@konn konn added the bug Something isn't working label Nov 29, 2024
@messense messense added the upstream Upstream issue label Nov 29, 2024
@messense messense pinned this issue Nov 29, 2024
@messense
Copy link
Member

messense commented Nov 29, 2024

Yeah I don't think we'll fix it on maturin side, but I've pinned it to increase visibility.

@messense messense added wontfix This will not be worked on and removed bug Something isn't working labels Nov 29, 2024
termoshtt added a commit to Jij-Inc/ommx that referenced this issue Dec 4, 2024
- Use twine 5.1.1 for validating wheels until
pypa/gh-action-pypi-publish#309 is merged.
- twine 5.1.1 does not supports metadata 2.4, thus fix `maturin ==
1.7.5` since it uses metadata 2.4 until 1.7.6
PyO3/maturin#2335
nikpau added a commit to nikpau/pytsa that referenced this issue Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Upstream issue wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants