Show full path in missing readme error message #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old error message: ```console $ maturin sdist --manifest-path ../mistral.rs/mistralrs-pyo3/Cargo.toml 🔗 Found pyo3 bindings 🐍 Found CPython 3.13 at /usr/local/bin/python3 📡 Using build options features from pyproject.toml 💥 maturin failed Caused by: Failed to build source distribution Caused by: failed to normalize readme path `/home/konsti/projects/mistral.rs/mistralrs-core/README.md` Caused by: No such file or directory (os error 2) ``` New error message: ```console maturin sdist --manifest-path ../mistral.rs/mistralrs-pyo3/Cargo.toml 🔗 Found pyo3 bindings 🐍 Found CPython 3.13 at /usr/local/bin/python3 📡 Using build options features from pyproject.toml 💥 maturin failed Caused by: Failed to build source distribution Caused by: failed to normalize readme path `/home/konsti/projects/mistral.rs/mistralrs-core/README.md` Caused by: No such file or directory (os error 2) ``` Checking at https://github.com/EricLBuehler/mistral.rs/blob/86599c1adc5e4a07db50e8460676151f736c873f/mistralrs-core/Cargo.toml#L3, there was indeed a missing readme file. Fixes #2060
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
konstin
added
bug
messense
approved these changes
May 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The CI failures look unrelated |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old error message:
New error message:
Checking at https://github.com/EricLBuehler/mistral.rs/blob/86599c1adc5e4a07db50e8460676151f736c873f/mistralrs-core/Cargo.toml#L3, there was indeed a missing readme file.
Fixes #2060