Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full path in missing readme error message #2074

Merged
merged 1 commit into from
May 12, 2024

Commits on May 9, 2024

  1. Show full path in missing readme error message

    Old error message:
    
    ```console
    $ maturin sdist --manifest-path ../mistral.rs/mistralrs-pyo3/Cargo.toml
     🔗 Found pyo3 bindings
     🐍 Found CPython 3.13 at /usr/local/bin/python3
     📡 Using build options features from pyproject.toml
     💥 maturin failed
       Caused by: Failed to build source distribution
       Caused by: failed to normalize readme path `/home/konsti/projects/mistral.rs/mistralrs-core/README.md`
       Caused by: No such file or directory (os error 2)
    ```
    
    New error message:
    
    ```console
    maturin sdist --manifest-path ../mistral.rs/mistralrs-pyo3/Cargo.toml
    🔗 Found pyo3 bindings
    🐍 Found CPython 3.13 at /usr/local/bin/python3
    📡 Using build options features from pyproject.toml
    💥 maturin failed
      Caused by: Failed to build source distribution
      Caused by: failed to normalize readme path `/home/konsti/projects/mistral.rs/mistralrs-core/README.md`
      Caused by: No such file or directory (os error 2)
    ```
    
    Checking at https://github.com/EricLBuehler/mistral.rs/blob/86599c1adc5e4a07db50e8460676151f736c873f/mistralrs-core/Cargo.toml#L3, there was indeed a missing readme file.
    
    Fixes #2060
    konstin committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ec333ea View commit details
    Browse the repository at this point in the history