Merge #2879

2879: Improve derive(FromPyObject) to apply intern! when applicable to get_item r=davidhewitt a=qbx2 This PR adds more `intern!`s to FromPyObject derive macro implementation. This should improve performance when using `#[pyo3(item)]`. Co-authored-by: Sunyeop Lee <sunyeop97@gmail.com>
PyO3 · Jan 15, 2023 · 713f51a · 713f51a
2 parents 556b3cf + 8026f35
commit 713f51a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/newsfragments/2879.changed.md b/newsfragments/2879.changed.md
@@ -0,0 +1 @@
+Improve `derive(FromPyObject)` to apply `intern!` when applicable to `#[pyo3(item)]`.
diff --git a/pyo3-macros-backend/src/frompyobject.rs b/pyo3-macros-backend/src/frompyobject.rs
@@ -315,8 +315,13 @@ impl<'a> Container<'a> {
                 FieldGetter::GetAttr(None) => {
                     quote!(getattr(_pyo3::intern!(obj.py(), #field_name)))
                 }
+                FieldGetter::GetItem(Some(syn::Lit::Str(key))) => {
+                    quote!(get_item(_pyo3::intern!(obj.py(), #key)))
+                }
                 FieldGetter::GetItem(Some(key)) => quote!(get_item(#key)),
-                FieldGetter::GetItem(None) => quote!(get_item(#field_name)),
+                FieldGetter::GetItem(None) => {
+                    quote!(get_item(_pyo3::intern!(obj.py(), #field_name)))
+                }
             };
             let extractor = match &field.from_py_with {
                 None => {