Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve derive(FromPyObject) to apply intern! when applicable to get_item #2879

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Improve derive(FromPyObject) to apply intern! when applicable to get_item #2879

merged 1 commit into from
Jan 15, 2023

Conversation

qbx2
Copy link
Contributor

@qbx2 qbx2 commented Jan 13, 2023 •
edited
Loading

This PR adds more intern!s to FromPyObject derive macro implementation. This should improve performance when using #[pyo3(item)].

@qbx2 qbx2 changed the title Improve derive(FromPyObject) to apply intern! when applicable Improve derive(FromPyObject) to apply intern! when applicable to get_item Jan 13, 2023
@davidhewitt davidhewitt force-pushed the improve-derive-frompyobject-apply-intern branch from 61e48b4 to 8026f35 Compare January 15, 2023 13:39
davidhewitt
davidhewitt approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Have force-pushed to squash, will merge now.

bors r+

bors bot added a commit that referenced this pull request Jan 15, 2023
@bors @qbx2
Merge #2879
7fcc8c1 
2879: Improve derive(FromPyObject) to apply intern! when applicable to get_item r=davidhewitt a=qbx2

This PR adds more `intern!`s to FromPyObject derive macro implementation. This should improve performance when using `#[pyo3(item)]`.


Co-authored-by: Sunyeop Lee <sunyeop97@gmail.com>
@davidhewitt davidhewitt mentioned this pull request Jan 15, 2023
Merged
@bors
Copy link
Contributor

bors bot commented Jan 15, 2023

Build failed:

@davidhewitt
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Jan 15, 2023

Build succeeded:

@bors bors bot merged commit 713f51a into PyO3:main Jan 15, 2023
qbx2 added a commit to qbx2/pyo3 that referenced this pull request Jan 26, 2023
@qbx2
Fix link for PyO3#2879
e637b39
bors bot added a commit that referenced this pull request Jan 26, 2023
@bors @qbx2
Merge #2919
e28789f 
2919: Fix link for #2879 r=mejrs a=qbx2

Fixes an incorrect link in changelog.

Co-authored-by: Sunyeop Lee <sunyeop97@gmail.com>
bors bot added a commit that referenced this pull request Jan 26, 2023
@bors @qbx2
Merge #2919
9004bd2 
2919: Fix link for #2879 r=mejrs a=qbx2

Fixes an incorrect link in changelog.

Co-authored-by: Sunyeop Lee <sunyeop97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qbx2 @davidhewitt