Refactor and Export Pyobject_* macros #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for interaction with other native python extensions, e.g. numpy Fixes #153
termoshtt
added a commit
to PyO3/rust-numpy
that referenced
this pull request
May 13, 2018
This was referenced May 13, 2018
|
Thank for your rapid action :) |
althonos
approved these changes
May 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you want to add other native types e.g. for https://github.com/termoshtt/rust-numpy. For those you need some conversions, which in pyo3 are implemented by macros. This pull request exports those macros so they are usable in other libraries. It also refactors the macros a bit, replacing calling
pyobject_convertandpyobject_nativetypewith a singlepyobject_native_type.@termoshtt Does this expose everything needed for rust-numpy?