Revise pyobject_* macro exports #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
requested changes
May 13, 2018
| @@ -1,4 +1,4 @@ | |||
| #![feature(specialization, proc_macro)] | |||
| #![feature(specialization, proc_macro, fn_must_use)] | |||
There was a problem hiding this comment.
This might be because you're nightly is an older one. Re-adding this gives a warning on recent nightlies:
warning: this feature has been stable since 1.27.0. Attribute no longer needed
--> src/lib.rs:1:40
|
1 | #![feature(specialization, proc_macro, fn_must_use)]
| ^^^^^^^^^^^
|
= note: #[warn(stable_features)] on by default
I've just increased the minimum required version to 1.27.0, so this should be caught by the build script in the future.
| @@ -59,10 +59,10 @@ macro_rules! pyobject_native_type_named( | |||
| ($name: ident) => { | |||
| impl $crate::PyNativeType for $name {} | |||
|
|
|||
| impl $crate::std::convert::AsRef<$crate::PyObjectRef> for $name { | |||
| impl ::std::convert::AsRef<$crate::PyObjectRef> for $name { | |||
There was a problem hiding this comment.
Does ::std have an advantage over $crate::std?
|
You should also take a look at the travis ci build. It looks like the python 2 module does also need some |
|
I'm closing this since the changes have been implemented in #186. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #155
exprandpathfor macro argumentsfn_must_useto reduce warnings