Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify pyobject_native_type to take path instead of ident #186

Merged
merged 3 commits into from
Jul 1, 2018
Merged

Modify pyobject_native_type to take path instead of ident #186

merged 3 commits into from
Jul 1, 2018

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Jul 1, 2018

So that we can use this macro outside this crate.
Almost same as #158.

kngwyu added 3 commits July 1, 2018 23:51
@kngwyu
Modify pyobject_native_type to take path instead of ident
3ec49b5 
So that we can use this macro outside this crate.
@kngwyu
Make python pub
70e1879
@kngwyu
$crate::std to ::std
41f4d1d 
So that we can use these macros in outer crates
@kngwyu
Copy link
Member Author

kngwyu commented Jul 1, 2018

Some notes:

  • we can't use a macro outside the crate, if we use $crate::std in it
  • we have to make python module public to export pyobject_native_type

@konstin
Copy link
Member

konstin commented Jul 1, 2018

Thank you!

@konstin konstin merged commit c22bec6 into PyO3:master Jul 1, 2018
@konstin konstin mentioned this pull request Jul 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kngwyu @konstin