opt: improve handle_panic generated code #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
python-tweaks
branch
from
3b6d347
to
29df11e
Compare
davidhewitt
force-pushed
the
python-tweaks
branch
from
29df11e
to
5be5d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing around with
cargo llvm-linesa bit on the PyO3 codebase to find chunky functions which might want optimizing a bit for compile times.pyo3::callback::handle_panicwas an obvious target - it's called in every generated function and it ends up being one of the biggest single contributors to lib size.Rearranging things a bit, and simplifying the
Unsendablehelper to remove the need forAssertUnwindSafemanaged to cut the size of this function by about a third. (RenamedUnsendabletoNotSend)As a bonus, I think I made the
NotSenderror message nicer - see the UI test.