opt: make argument extraction code smaller #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
opt-argument-extraction
branch
3 times, most recently
from
c7c7fb8
to
b0be6de
Compare
davidhewitt
force-pushed
the
opt-argument-extraction
branch
from
b0be6de
to
90479dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2074, I found that the
#[pyfunction]argument extraction code also had a fairly chunky LLVM line count.Although not a perfect metric, is definitely linked to compile times.
Overall makes the LLVM line count of
pyo3-pytestsabout 10% smaller, which seems pretty decent!