Move links key from pyo3 to pyo3-ffi #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipt has finished before pyo3's build script starts.
adamreichold
force-pushed
the
build-require-pyo3-ffi
branch
from
5a218c3 to
0c7a13f
Compare
|
I don't think this will necessarily help? The problem is that this PR will cause Even if the build script runs for the host build, it won't get the right information from cargo to detect cross compiles. |
I it is indeed built twice but the (useless) version for the host does not write the cross-comilation-specific file, does it? In any case, I think this appears to fix things because it seems to ensure that both build script builds of Log of building `pyo3-ffi` and `pyo3` with this change |
|
So the CI failure show that this is a bad idea in any case as the host build of |
Instead of a fake build dependency, move the links key from pyo3 to pyo3-ffi which according to [1] is a prerequisite for build scripts to emit meta-data that can be used by other build scripts which would incidentally ensure the ordering between the build script of pyo3 and pyo3-ffi that we need. [1] https://doc.rust-lang.org/cargo/reference/build-script-examples.html#using-another-sys-crate
adamreichold
force-pushed
the
build-require-pyo3-ffi
branch
from
415f8c0 to
1e7275c
Compare
|
Another try: Instead of a fake build dependency, move the (I think the |
|
That sounds likely to be a correct fix to me! |
This comment was marked as resolved.
This comment was marked as resolved.
adamreichold
force-pushed
the
build-require-pyo3-ffi
branch
from
311123b to
1e7275c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
adamreichold
changed the title
messense
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that its build script has finished before pyo3's build script starts. The extra dependency edge enables reliably passing configuration files like
pyo3-cross-compile-config.txtcreated bypyo3-ffi's build script to the one ofpyo3.Closes #2222