Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git repository and edit urls to user guide #2635

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Add git repository and edit urls to user guide #2635

merged 1 commit into from
Sep 23, 2022

Conversation

messense
Copy link
Member

@messense messense commented Sep 22, 2022 •
edited
Loading

@messense messense added the CI-skip-changelog Skip checking changelog entry label Sep 22, 2022
@adamreichold
Copy link
Member

Pinging #2612 due to the test failures.

@Psykopear
Copy link
Contributor

Sorry, opened a PR with the fix: #2636

davidhewitt
davidhewitt approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

CI failure looks related to maturin-action?

@messense
Copy link
Member Author

I think it's the hot out of the oven Rust 1.64.0: https://blog.rust-lang.org/2022/09/22/Rust-1.64.0.html

@messense
Copy link
Member Author

messense commented Sep 22, 2022 •
edited
Loading

Rust 1.64.0 requires GLIBC 2.17+, so we need to change manylinux: auto in ci.yml to manylinux: 2014.

Edit: I'm changing the default in maturin-action instead PyO3/maturin-action#83

@davidhewitt
Copy link
Member

Thanks. I also pushed #2637 for the other pieces here

@messense messense enabled auto-merge (squash) September 23, 2022 00:36
@messense messense merged commit 86ce4d1 into PyO3:main Sep 23, 2022
@messense messense deleted the mdbook-edit branch September 23, 2022 00:56
davidhewitt pushed a commit that referenced this pull request Sep 29, 2022
@messense @davidhewitt
Add git repository and edit urls to user guide (#2635)
fc52a63
davidhewitt pushed a commit that referenced this pull request Sep 29, 2022
@messense @davidhewitt
Add git repository and edit urls to user guide (#2635)
fa6e199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@messense @adamreichold @Psykopear @davidhewitt