Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong proptest in chrono conversion module #2636

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Fixed wrong proptest in chrono conversion module #2636

merged 1 commit into from
Sep 22, 2022

Conversation

Psykopear
Copy link
Contributor

Two of the proptests in the chrono module were using an out of bound value to initialize a FixedOffset (see here) , this slipped during review.

This was referenced Sep 22, 2022
Merged
Merged
@messense messense added the CI-skip-changelog Skip checking changelog entry label Sep 22, 2022
davidhewitt
davidhewitt approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidhewitt davidhewitt merged commit 486f54f into PyO3:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense approved these changes

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Psykopear @messense @davidhewitt