Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PyGCProtocol in test class #530

Merged
merged 1 commit into from
Jul 14, 2019
Merged

Conversation

Alexander-N
Copy link
Member

For the garbage collection to work the PyGCProtocol has to be
implemented. Ideally it should not even get compiled if it doesn't since
a missing tp_traverse can produce a segfault.

Issues #323 #395

For the garbage collection to work the PyGCProtocol has to be
implemented. Ideally it should not even get compiled if it doesn't since
a missing tp_traverse can produce a segfault.
@codecov
Copy link

codecov bot commented Jul 14, 2019

Codecov Report

Merging #530 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
+ Coverage   87.55%   87.56%   +0.01%     
==========================================
  Files          65       65              
  Lines        3440     3443       +3     
==========================================
+ Hits         3012     3015       +3     
  Misses        428      428
Impacted Files Coverage Δ
src/class/gc.rs 94.59% <0%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a56fa...72339e5. Read the comment docs.

@kngwyu
Copy link
Member

kngwyu commented Jul 14, 2019

Thanks but... isn't this PR overlap #531?

@pganssle
Copy link
Member

@kngwyu No, the two are complementary (and in fact this one needs to be merged first). PR #531 enforces at compile time that you implement PyGCProtocol for anything using the gc flag. This PR implements PyGCProtocol for the objects in the test suite that are using the gc flag.

@kngwyu
Copy link
Member

kngwyu commented Jul 14, 2019

@pganssle
I see, thanks.

@kngwyu kngwyu merged commit 670b41c into PyO3:master Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants