Enforce GC contract at compile time #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
force-pushed
the
enforce_gc_protocol
branch
from
93ad3ce
to
d7ffdfc
Compare
|
Good catch, 👍 for this PR |
pganssle
force-pushed
the
enforce_gc_protocol
branch
from
d7ffdfc
to
11950fa
Compare
pganssle
commented
Jul 14, 2019
kngwyu
reviewed
Jul 14, 2019
Alexander-N
added a commit
to Alexander-N/pyo3
that referenced
this pull request
Jul 14, 2019
Implementations for these methods should always be provided. See PyO3#531
pganssle
force-pushed
the
enforce_gc_protocol
branch
from
11950fa
to
c953e3a
Compare
PyGCProtocol must be implemented for anything registered as tracked by the garbage collector. This modifies the `pyclass` macro to enforce this at compile time.
pganssle
changed the title
pganssle
force-pushed
the
enforce_gc_protocol
branch
from
c953e3a
to
e633ae2
Compare
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
==========================================
- Coverage 87.68% 87.56% -0.12%
==========================================
Files 65 65
Lines 3443 3443
==========================================
- Hits 3019 3015 -4
- Misses 424 428 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
==========================================
- Coverage 87.68% 87.56% -0.12%
==========================================
Files 65 65
Lines 3443 3443
==========================================
- Hits 3019 3015 -4
- Misses 424 428 +4
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyGCProtocol must be implemented for anything registered as tracked by the garbage collector. This modifies the
pyclassmacro to enforce this at compile time.