-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsound return of borrowed objects #890
Conversation
In case we're worried about performance regressions, I made some benchmarks (from #891). I ran them on Results:
Conclusions:
So I would be really keen to see this safety gap closed. If we are really worried about performance we could add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you!
As per feedback on PyO3#890
I've undone the change for |
As per feedback on PyO3#890
1579307
to
e7703d5
Compare
As per feedback on PyO3#890
e7703d5
to
6f74fe6
Compare
Thank you! |
As discussed in #883, I think these are a few cases where we should be converting borrowed objects to owned objects for safety reasons.
Closes #883.