Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New benchmarks #891

Merged
merged 2 commits into from
May 3, 2020
Merged

New benchmarks #891

merged 2 commits into from
May 3, 2020

Conversation

davidhewitt
Copy link
Member

I threw some benchmarks together to evaluate #890. Thought it better to submit them in a separate PR.

Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
But I don't understand why we need create_many_pyclass, set_property and get_property.
Maybe we need some short comments that explain the point to aim at?

benches/bench_pyclass.rs Outdated Show resolved Hide resolved
benches/bench_pyclass.rs Outdated Show resolved Hide resolved
@davidhewitt
Copy link
Member Author

👍 for now I've just removed bench_pyclass.

I did some benchmarking a while ago in Python using timeit where I found that a simple pyclass was slower than a simple dict. I'd like to add these benchmarks to the pyo3 repo eventually, but really they need to be .py benchmarks, so I will add them back another time.

@kngwyu
Copy link
Member

kngwyu commented May 3, 2020

I'd like to add these benchmarks to the pyo3 repo eventually, but really they need to be .py benchmarks, so I will add them back another time.

We have a benchmark using pytest. Maybe it's helpful to take a glance at it.

@kngwyu
Copy link
Member

kngwyu commented May 3, 2020

Thank you!

@kngwyu kngwyu merged commit 78c51d3 into PyO3:master May 3, 2020
@davidhewitt
Copy link
Member Author

We have a benchmark using pytest. Maybe it's helpful to take a glance at it.

Ah nice, I will be sure to play around with that some time 👍

@davidhewitt davidhewitt deleted the benches branch August 10, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants