Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow #[classattr] on associated constants #914

Merged
merged 2 commits into from
May 9, 2020
Merged

Allow #[classattr] on associated constants #914

merged 2 commits into from
May 9, 2020

Conversation

scalexm
Copy link
Contributor

@scalexm scalexm commented May 8, 2020 

#[pymethods]
impl Foo {
    #[classattr]
    const MY_CONST: &'static str = "foobar";
}

davidhewitt
davidhewitt reviewed May 8, 2020
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very pleased to see this 👍

pyo3-derive-backend/src/pymethod.rs Show resolved Hide resolved
pyo3-derive-backend/src/pymethod.rs Outdated
pub fn impl_py_class_attribute(spec: &FnSpec<'_>, wrapper: &TokenStream) -> TokenStream {
let python_name = &spec.python_name;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why you did this refactoring but I think I preferred how it was before, to keep symmetry with the the other impl_py_method_xyz functions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitated making this change indeed. I’ll write two functions, it’ll duplicate code slightly but will preserve the symmetry.

@davidhewitt
Copy link
Member

Also I think the original #905 missed off a CHANGELOG entry, so can you add one here?

(Might want to wait to rebase on #915 to make life easier.)

kngwyu
kngwyu approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@scalexm scalexm mentioned this pull request May 8, 2020
Merged
@kngwyu
Copy link
Member

kngwyu commented May 9, 2020

Thank you!

@kngwyu kngwyu merged commit 818ebf7 into PyO3:master May 9, 2020
@davidhewitt davidhewitt mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt left review comments

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scalexm @davidhewitt @kngwyu