Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up CHANGELOG to match keep-a-changelog more closely #915

Merged
merged 1 commit into from
May 8, 2020
Merged

Clean up CHANGELOG to match keep-a-changelog more closely #915

merged 1 commit into from
May 8, 2020

Conversation

davidhewitt
Copy link
Member

Cleaned up the CHANGELOG to be more consistent with https://keepachangelog.com

  • Changed * to - for bullets
  • Removed unnecessary newlines
  • Added missing release dates
  • Added missing links
  • Changed order of sections to always be Added / Changed / Removed / Fixed (to match the order on keep-a-changelog).

@davidhewitt davidhewitt mentioned this pull request May 8, 2020
Merged
@davidhewitt
Copy link
Member Author

Will rebase quickly after merge of #911...

kngwyu
kngwyu approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this hard work!
I also feel * not good but have left it as is because of my laziness 😅

@kngwyu
Copy link
Member

kngwyu commented May 8, 2020

Hmm, travis goes wrong 🤔
Could please push --force again?

@davidhewitt
Copy link
Member Author

👍 travis looks alive this time so fingers crossed

@kngwyu
Copy link
Member

kngwyu commented May 8, 2020

Thanks!

@kngwyu kngwyu merged commit ab374b4 into PyO3:master May 8, 2020
@davidhewitt davidhewitt deleted the keep-a-changelog branch August 10, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @kngwyu