Voice Receiving #532
Merged
CodeWithSwastik merged 32 commits intoPycord-Development:feature/voice-receivefrom Dec 20, 2021
Merged
Voice Receiving #532CodeWithSwastik merged 32 commits intoPycord-Development:feature/voice-receivefrom
CodeWithSwastik merged 32 commits intoPycord-Development:feature/voice-receivefrom
Conversation
Initial Unchanged Implementation from the discord.py pull
I formatted some of the Voice files since no-one is changing them else than me currently and added more versionadded's
Closed
BobDotCom
added
feature
…ycord into support/voice/recording
|
hello |
Contributor
Author
|
@BobDotCom if you could move this into V2.0 that would be great |
Lulalaby
added
status: awaiting review
CodeWithSwastik
previously approved these changes
Dec 19, 2021
Contributor
CodeWithSwastik
left a comment
CodeWithSwastik
left a comment
There was a problem hiding this comment.
I've tested it and it works perfectly. Haven't gone through the code thoroughly yet.
Co-Authored-By: Swas.py <61446939+CodeWithSwastik@users.noreply.github.com>
auto-merge was automatically disabled
December 19, 2021 06:10
Head branch was pushed to by a user without write access
Contributor
|
This can be merged when the hardcoded os stuff is removed and bytes are supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Voice Recording Stabilizing & Building Off Of Rapptz/discord.py#6507
Checklist
Possibly Rename SinkBugs
When 2 People Talk There Is StaticChecklist