Skip to content

[WIP] Voice Receiving #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
VincentRPS wants to merge 6 commits into from
Closed

[WIP] Voice Receiving #590

VincentRPS wants to merge 6 commits into from

Conversation

@VincentRPS
Copy link
Contributor

@VincentRPS VincentRPS commented Dec 20, 2021

Summary

Supersedes #532
Closes #52

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

VincentRPS and others added 6 commits December 20, 2021 13:11
@VincentRPS @CodeWithSwastik
Voice Receiving (#532)
046380a 
* Implementation Of Rapptz/discord.py#6507

Initial Unchanged Implementation from the discord.py pull

* Implement Fix

* Advances Docstrings in sink

* Implement Fixes

I formatted some of the Voice files since no-one is changing them else than me currently and added more versionadded's

* Should Decrease Static By A Bit

* Fixes & Docs

* Fix

* Fix Indents

* Switch Example To Use MP3

* Adding PCM As Ignored

* Fixes

* Fix Static Error

* Fix RecordingException Docs

* Fix ValueErrors

* Changing Version Added To 2.0

* Details

* Fix My Visual Studio Setup

* Typo

* Better Filters Docstring

* Fix

* Fix Version Info

* Fix

* Redo Voice Example To Use Bot Instead of Client

Co-Authored-By: Swas.py <61446939+CodeWithSwastik@users.noreply.github.com>

* Fix Typo

https://discord.com/channels/881207955029110855/881735314987708456/922020659394129940

* Replace `ClientException`s to `SinkException`s

* Adding ``.pycord`` tempdir

* revert tempdir

Co-authored-by: Vincent <82736662+RPSMain@users.noreply.github.com>
Co-authored-by: Swas.py <61446939+CodeWithSwastik@users.noreply.github.com>
@CodeWithSwastik
Rename start_recording to listen and stop_recording to stop_listening
89ac42f
@CodeWithSwastik
Rename stop_recording to stop_listening in sink.py
6948109
@CodeWithSwastik
Rename filter_decorator to interface
ceef5db
@CodeWithSwastik
Fix renames
7f3f9ca
@CodeWithSwastik
Fix renames and remove print
740c41e
@Middledot Middledot added feature Implements a feature priority: low Low Priority status: in progress Work in Progess labels Dec 22, 2021
@Lulalaby Lulalaby added this to the v2.0 milestone Jan 7, 2022
@Lulalaby Lulalaby closed this Jan 10, 2022
@Lulalaby Lulalaby deleted the feature/voice-receive branch January 28, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature Implements a feature priority: low Low Priority status: in progress Work in Progess

Projects

None yet

Milestone

v2.0

Development

Successfully merging this pull request may close these issues.

Voice Receive API

4 participants

@VincentRPS @Lulalaby @Middledot @CodeWithSwastik