-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a function for cubic spline interpolation #3216
base: main
Are you sure you want to change the base?
Conversation
We discussed in the weekly dev call and expressed that this PR sounds interesting / useful. If you have time, @eslickj , please feel free to push forward with it. |
@mrmundt, Thanks! I think it's all there and functioning properly. I'll write tests as I have time. |
@mrmundt, I added tests. |
@eslickj - The failing test is indicating that you have a missing |
@mrmundt, I added the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall in good shape. Some minor changes... @eslickj, let us know if you want to make them or if you want one of us to cover it.
pyomo/contrib/cspline_external/test/test_parameter_calculation.py
Outdated
Show resolved
Hide resolved
pyomo/contrib/cspline_external/test/test_parameter_calculation.py
Outdated
Show resolved
Hide resolved
@jsiirola, thanks! I should be able to make the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eslickj I found a few minor things that should be fixed
pyomo/contrib/cspline_external/test/test_parameter_calculation.py
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3216 +/- ##
==========================================
+ Coverage 88.65% 88.67% +0.01%
==========================================
Files 882 887 +5
Lines 101133 101422 +289
==========================================
+ Hits 89662 89933 +271
- Misses 11471 11489 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary/Motivation:
This adds an external function for cubic spline interpolation. I couldn't find this functionality in Pyomo, but I may have missed something. This is just a draft. I wanted to see if this is worth finishing. I can finish cleaning this up and adding tests or close it. I need functionality similar to this for pump and fan curves.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: