Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split changelog workflows to separate logic on when each gets run #1410

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

waylan
Copy link
Member

@waylan waylan commented Nov 6, 2023

No description provided.

@waylan
Copy link
Member Author

waylan commented Nov 6, 2023

Hmm, neither of the changelog workflows should be running in this PR as the requirements are not met for either (no changes were made in markdown/ and no changes to the changelog). This used to work before the change in #1388. I thought that if we separated out the validation, then the previous behavior would return. Not sure what I'm missing here.

@oprypin
Copy link
Contributor

oprypin commented Nov 6, 2023

@waylan
Copy link
Member Author

waylan commented Nov 6, 2023

Probably there's a typo
paths path

That was it. Thank you. 😊

Strangely, that was not changed in #1388. Now I'm not sure when that stopped working.

@waylan waylan merged commit bc14d59 into Python-Markdown:master Nov 6, 2023
12 checks passed
@waylan waylan deleted the changelogwf branch November 6, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants