Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split changelog workflows to separate logic on when each gets run #1410

Merged
merged 3 commits into from
Nov 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,23 +1,16 @@
name: changelog
name: changelog-enforcer

on:
pull_request:
branches:
- '**'
path:
# Only run if changes were made in markdown/ or the changelog
paths:
# Only run if changes were made in markdown/
- 'markdown/**'
- 'docs/changelog.md'

# permissions:
# pull-requests: write

jobs:
validate:
check-for-entry:

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Ensure Changelog Entry Made
uses: dangoslen/changelog-enforcer@v3
with:
Expand All @@ -27,10 +20,3 @@ jobs:
changelog describing the changes you have made. Doing so will help to ensure your contribution is accepted.

Please see the [Contributing Guide](https://python-markdown.github.io/contributing/#changelog) for details.
- name: Validate Changelog
if: success()
id: changelog_reader
uses: mindsers/changelog-reader-action@v2
with:
validation_level: error
path: docs/changelog.md
20 changes: 20 additions & 0 deletions .github/workflows/changelog-validator.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: changelog-validator

on:
pull_request:
paths:
# Only run if changes were made to the changelog
- 'docs/changelog.md'

jobs:
validate:

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Validate Changelog
id: changelog_reader
uses: mindsers/changelog-reader-action@v2
with:
validation_level: error
path: docs/changelog.md