Linear mapping + tests #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncourty
approved these changes
May 9, 2018
| * Wasserstein Discriminant Analysis [11] (requires autograd + pymanopt). | ||
| * Gromov-Wasserstein distances and barycenters [12] | ||
| * Gromov-Wasserstein distances and barycenters ([13] and regularized [12]) |
Makefile
Outdated
| @@ -41,7 +41,7 @@ pep8 : | |||
| flake8 examples/ ot/ test/ | |||
|
|
|||
| test : FORCE pep8 | |||
| python -m py.test -v test/ --cov=ot --cov-report html:cov_html | |||
| $(PYTHON) -m pytest -v test/ --cov=ot --cov-report html:cov_html | |||
|
|
|||
| pytest : FORCE | |||
| python -m py.test -v test/ --cov=ot | |||
There was a problem hiding this comment.
yes its defined at the top of the file.
I will put it for every call to python.
README.md
Outdated
|
|
||
| [14] Knott, M. and Smith, C. S. [On the optimal mapping of distributions](https://link.springer.com/article/10.1007/BF00934745), Journal of Optimization Theory and Applications Vol 43, 1984. | ||
|
|
||
| [15] Peyré, G., & Cuturi, M. (2017). [Computational Optimal Transport](https://arxiv.org/pdf/1803.00567.pdf) , 2018. |
docs/source/readme.rst
Outdated
| distributions <https://link.springer.com/article/10.1007/BF00934745>`__, | ||
| Journal of Optimization Theory and Applications Vol 43, 1984. | ||
|
|
||
| [15] Peyré, G., & Cuturi, M. (2017). `Computational Optimal |
ot/da.py
Outdated
| wt=None, bias=True, log=False): | ||
| """ return OT linear operator between samples | ||
|
|
||
| The function estimate the optimal linear operator that align the two |
ot/da.py
Outdated
|
|
||
| The function estimate the optimal linear operator that align the two | ||
| empirical distributions. This is equivalent to estimating the closed | ||
| form mapping between two Gaussian distribution :math:`N(\mu_s,\Sigma_s)` |
ot/da.py
Outdated
| xt : np.ndarray (nt,d) | ||
| samples in the target domain | ||
| reg : float,optional | ||
| regularization added to the daigonals of convariances (>0) |
ot/da.py
Outdated
| class LinearTransport(BaseTransport): | ||
| """ OT linear operator between empirical distributions | ||
|
|
||
| The function estimate the optimal linear operator that align the two |
There was a problem hiding this comment.
same typos here that for the corresponding function
|
OK I'm merging, thank you @ncourty for the code review. We now have 91% line coverage! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I added the following: