-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Precommit hook (darker/linting) and Updates to Docs #110
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 79.67% 80.15% +0.47%
==========================================
Files 16 16
Lines 2367 2368 +1
==========================================
+ Hits 1886 1898 +12
+ Misses 481 470 -11
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@trevormorgan I think this is ready to merge. The final thing is to run the pre-commit hook and commit the changes.
|
Thanks @jenshnielsen, updates due to the precommit run have been pushed. I added in some changes to documentation that should be reviewed as well. Mainly modernizing with nbsphinx in the conf.py and adding in the example notebooks to the index.rst |
Now you will also need to adapt https://github.com/QCoDeS/broadbean/blob/master/.github/workflows/docs.yaml to actually call sphinx |
…oDeS/broadbean into trmorgan/darker_and_precommit
I am not sure why the conda build requires versioningit. It should not since it installs a wheel that has already had the version number logic replaced |
@jenshnielsen I'm a bit perplexed by this one as well. I haven't dug into much yet though so I'll see what I can find out. |
I suggest that we simply get rid of it #139 |
Do not merge until #109 lands