Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Precommit hook (darker/linting) and Updates to Docs #110

Merged
merged 22 commits into from
Jun 29, 2022

Conversation

trevormorgan
Copy link
Contributor

@trevormorgan trevormorgan commented Jun 5, 2022

Do not merge until #109 lands

  • add precommit
  • enable darker
  • Update sphinx docs
  • Add in examples to documentation

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2022

Codecov Report

Merging #110 (a22a739) into master (2875470) will increase coverage by 0.47%.
The diff coverage is 56.06%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   79.67%   80.15%   +0.47%     
==========================================
  Files          16       16              
  Lines        2367     2368       +1     
==========================================
+ Hits         1886     1898      +12     
+ Misses        481      470      -11     
Impacted Files Coverage Δ
broadbean/plotting.py 0.00% <0.00%> (ø)
broadbean/broadbean.py 61.79% <37.50%> (ø)
broadbean/element.py 88.77% <57.14%> (ø)
broadbean/sequence.py 72.46% <58.33%> (+0.40%) ⬆️
broadbean/blueprint.py 89.18% <66.66%> (ø)
broadbean/__init__.py 100.00% <100.00%> (ø)
broadbean/tests/test_awgfilegeneration.py 98.57% <0.00%> (+2.85%) ⬆️
broadbean/_version.py 100.00% <0.00%> (+100.00%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@trevormorgan trevormorgan changed the title Trmorgan/darker and precommit Adding precommit hook with darker linting Jun 5, 2022
@trevormorgan trevormorgan marked this pull request as ready for review June 27, 2022 18:03
@jenshnielsen
Copy link
Contributor

@trevormorgan I think this is ready to merge. The final thing is to run the pre-commit hook and commit the changes.

 pre-commit run --all

@trevormorgan trevormorgan changed the title Adding precommit hook with darker linting Enable Precommit hook (darker/linting) and Updates to Docs Jun 27, 2022
@trevormorgan
Copy link
Contributor Author

trevormorgan commented Jun 27, 2022

@trevormorgan I think this is ready to merge. The final thing is to run the pre-commit hook and commit the changes.

 pre-commit run --all

Thanks @jenshnielsen, updates due to the precommit run have been pushed. I added in some changes to documentation that should be reviewed as well. Mainly modernizing with nbsphinx in the conf.py and adding in the example notebooks to the index.rst

docs/Makefile Outdated Show resolved Hide resolved
@jenshnielsen
Copy link
Contributor

Now you will also need to adapt https://github.com/QCoDeS/broadbean/blob/master/.github/workflows/docs.yaml to actually call sphinx

requirements.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/Makefile Outdated Show resolved Hide resolved
@jenshnielsen
Copy link
Contributor

I am not sure why the conda build requires versioningit. It should not since it installs a wheel that has already had the version number logic replaced

@trevormorgan
Copy link
Contributor Author

I am not sure why the conda build requires versioningit. It should not since it installs a wheel that has already had the version number logic replaced

@jenshnielsen I'm a bit perplexed by this one as well. I haven't dug into much yet though so I'll see what I can find out.

@jenshnielsen
Copy link
Contributor

I suggest that we simply get rid of it #139

@jenshnielsen jenshnielsen merged commit 51cc051 into master Jun 29, 2022
@jenshnielsen jenshnielsen deleted the trmorgan/darker_and_precommit branch June 29, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants