Language is not being applied correctly

[d-l-n]

My OS language is set on Spanish (es) but app keeps showing all texts in English and there isn't any manual way to change it (at least i didn't find it and repo doesn't says anything about it)

[xupefei]

It reads and matches your UI language.
Is your Start Menu in Spanish?

[d-l-n]

Yes, I have everything in Spanish

[xupefei]

I think there's a bug in finding a translation: https://github.com/QL-Win/QuickLook.Common/blob/master/Helpers/TranslationHelper.cs#L56
locale.Parent.Name should be changed to locale.TwoLetterISOLanguageName.

Do you have developing exp to test this fix? If not I'll find some time tod test it.

[d-l-n]

I'm starting at coding but tell me what to do & I'll try

[xupefei]

Nevermind, I got some time to debug.
Could you download this DLL and overwrite the same file in the installation folder (you'll need MSI or ZIP version)?
When running QL it will pop up multiple message boxes. What are their contents?

QuickLook.Common.zip

[d-l-n]

i have msi version but i dont see any QuickLook.Common.dll file in app dir

[xupefei]

It's located aside QuickLook.exe.

[d-l-n]

i replaced it but now QuickLook doesn't starts. I tried rebooting OS but nothing

[xupefei]

Got it. I'll give you are full test package tomorrow.

[xupefei]

Try this one:
QuickLookUITest.zip

[d-l-n]

[xupefei]

If you right click on the tray icon, what language is the menu in?

[d-l-n]

Spanish!!

[xupefei]

So it's correct now, whereas in the release version you see English?

[d-l-n]

yes it's showing text correctly

[xupefei]

I don't get it. What is your issue then?

[d-l-n]

The QL languague keeps in English. With the files you sent me the app shows texts in OS lang (es) but only when I right click on tray icon (#941 (comment)) and QL doesnt work anymore, just shows the message boxes.

[d-l-n]

the issue is that QL is not recognizing the language and there's no manual way to select it neither

[xupefei]

Do you mean: with QuickLookUITest.zip you see the context menu in Spanish, but with the official release the same context menu is in English?

[d-l-n]

Exactly

[rabelux]

Ok so your issue is fixed if you use the latest zip file, right?
If not then please provide screenshots as I'm also getting confused.

[d-l-n]

Look, WITH QuickLookUITest.zip tray icon options are displayed in my language

BUT when I try to use QL to see files preview it shows this boxes (#941 (comment)) so idk if the strings of file previews are showing translated

WITHOUT QuickLookUITest.zip all the strings (in previews and tray icon) are always in English (i use Spanish)

Tray icon in latest release (should be in Spanish):

File preview in latest release (should be in Spanish):

[xupefei]

https://ci.appveyor.com/project/xupefei/quicklook/builds/39767002/artifacts should fix your issue. Please try and report back!

[d-l-n]

Yes!! Thanks!

The only thing, compressed files previews shows strings in English but I think it's related to ArchiveViewer plugin