Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate runtime tutorials #1149

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Migrate runtime tutorials #1149

merged 5 commits into from
Apr 9, 2024

Conversation

frankharkins
Copy link
Member

Adds the runtime tutorial notebooks as per #1135. I couldn't use the same approach as #91 as the file history is broken in the runtime repo, but since there were few enough files I used git log --follow to find the original PR and all authors that touched the files.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sgtm to manually do co-authors.

About the file organization:

  1. What other top-level folders are you envisioning beyond runtime?
  2. Why have the folders with single files, rather than flattening that?

@frankharkins
Copy link
Member Author

frankharkins commented Apr 9, 2024

What other top-level folders are you envisioning beyond runtime?

Good question. I'm not sure; I just named the folder based on their origin but I think it would also be OK to remove that layer too. EDIT: Spoke to Abby and she agrees with removing that layer.

Why have the folders with single files, rather than flattening that?

If we want to include separate images we need to upload a folder of the following form. We don't have any images yet but I thought it would be easier to start with this form.

tutorial-name
├── images/
└── notebook.ipynb

@Eric-Arellano
Copy link
Collaborator

Can the file be called notebook.ipynb? Avoid the repetition.

frankharkins and others added 5 commits April 9, 2024 15:44
Originally created in Qiskit/qiskit-ibm-runtime#231

Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Kevin Tian <kevin.tian@ibm.com>
Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Sanket Panda <pandasa123@gmail.com>
Originally created in Qiskit/qiskit-ibm-runtime#235

Co-authored-by: ElePT <epenatap@gmail.com>
Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: Jim Garrison <garrison@ibm.com>
Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Kevin Tian <kt474@cornell.edu>
Co-authored-by: Paul Nation <nonhermitian@gmail.com>
Co-authored-by: Rathish Cholarajan <rathish.c@ibm.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Sanket Panda <pandasa123@gmail.com>
Co-authored-by: jspark971 <jspark971@gmail.com>
Co-authored-by: kevin-tian <kevin.tian@ibm.com>
Co-authored-by: lerongil <leron_1234@yahoo.com>
Originally created in Qiskit/qiskit-ibm-runtime#888

Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Co-authored-by: Hwajung Kang <hwajungkang@gmail.com>
Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
Co-authored-by: Kevin Tian <kevin.tian@ibm.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Sanket Panda <pandasa123@gmail.com>
Originally created in Qiskit/qiskit-ibm-runtime#416

Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: Kevin Tian <kevin.tian@ibm.com>
Co-authored-by: Paul Nation <nonhermitian@gmail.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Sanket Panda <pandasa123@gmail.com>
Co-authored-by: Tushar Mittal <37920727+tmittal947@users.noreply.github.com>
Co-authored-by: adcorcol <1413901+adcorcol@users.noreply.github.com>
Originally created in Qiskit/qiskit-ibm-runtime#236

Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: Jim Garrison <garrison@ibm.com>
Co-authored-by: Kevin Tian <kevin.tian@ibm.com>
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
Co-authored-by: Paul Nation <nonhermitian@gmail.com>
Co-authored-by: Rathish Cholarajan <rathish.c@ibm.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Sanket Panda <pandasa123@gmail.com>
Co-authored-by: beckykd <66339736+beckykd@users.noreply.github.com>
Co-authored-by: kevin-tian <kevin.tian@ibm.com>
@frankharkins frankharkins merged commit 56a925e into main Apr 9, 2024
2 checks passed
@frankharkins frankharkins deleted the FH/migrate-tutorials branch April 9, 2024 16:21
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Adds the runtime tutorial notebooks as per Qiskit#1135. I couldn't use the
same approach as Qiskit#91 as the file history is broken in the runtime repo,
but since there were few enough files I used `git log --follow` to find
the original PR and all authors that touched the files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants