Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user-transpiled circuits tutorial #231

Merged
merged 20 commits into from
Apr 8, 2022

Conversation

frankharkins
Copy link
Member

Summary

Add short tutorial showing users how to submit user-transpiled circuits via sampler primitive.

@frankharkins frankharkins marked this pull request as draft March 23, 2022 14:01
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@frankharkins frankharkins marked this pull request as ready for review March 23, 2022 14:45
@lockwo
Copy link
Contributor

lockwo commented Mar 24, 2022

Should the first histogram have any labels (axes)?

@coveralls
Copy link

coveralls commented Mar 24, 2022

Pull Request Test Coverage Report for Build 2114578527

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 68.355%

Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/runtime_session.py 7 40.63%
Totals Coverage Status
Change from base Build 2106641349: -0.05%
Covered Lines: 2631
Relevant Lines: 3849

💛 - Coveralls

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
@frankharkins
Copy link
Member Author

frankharkins commented Mar 24, 2022

Seems the histograms aren't rendering correctly through the github image viewer, I think because my format is svg. I think they should render correctly in the docs but we should check before we push to production.

Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, suggested a few changes...

docs/tutorials/user-transpiled-circuits.ipynb Show resolved Hide resolved
docs/tutorials/user-transpiled-circuits.ipynb Outdated Show resolved Hide resolved
docs/tutorials/user-transpiled-circuits.ipynb Outdated Show resolved Hide resolved
Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot @frankharkins!

@rathishcholarajan rathishcholarajan merged commit c85e7ad into Qiskit:main Apr 8, 2022
@frankharkins frankharkins deleted the primitive-tutorial branch April 8, 2022 19:20
frankharkins added a commit to Qiskit/documentation that referenced this pull request Apr 9, 2024
Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Kevin Tian <kevin.tian@ibm.com>
Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Sanket Panda <pandasa123@gmail.com>
frankharkins added a commit to Qiskit/documentation that referenced this pull request Apr 9, 2024
Originally created in Qiskit/qiskit-ibm-runtime#231

Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Kevin Tian <kevin.tian@ibm.com>
Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Sanket Panda <pandasa123@gmail.com>
frankharkins added a commit to Qiskit/documentation that referenced this pull request Apr 9, 2024
Originally created in Qiskit/qiskit-ibm-runtime#231

Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Kevin Tian <kevin.tian@ibm.com>
Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Sanket Panda <pandasa123@gmail.com>
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Originally created in Qiskit/qiskit-ibm-runtime#231

Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Kevin Tian <kevin.tian@ibm.com>
Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Sanket Panda <pandasa123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants