-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganise "Save jobs" page #1203
Conversation
This lets us avoid hardcoding the `job_id`, which means anyone can run the notebook successfully (rather than just Frank).
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Are we confident that CI will always have jobs run in the past day, the next time we go to regenerate this notebook? Would it instead be safer to do something like past 3 days or past week? It won't fail if no jobs were run in the past day, but the output would be empty
It think it's likely it might not, but IMO empty output is OK. Open to other suggestions though. |
You could change it to the past week. Or probably even better: ask for all jobs but use a slice to only show up to 3, >>> [1,2,3,4,5][:3]
[1, 2, 3]
>>> [1][:3]
[1] |
I quite like the |
As a compromise, I went with the last 90 days as |
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
This page originally submitted a simple job using the cloud simulator as a demonstration. Since the simulators are being deprecated, Qiskit#1160 removed the job-submitting step and hardcoded the `job_id` into the notebook. This was a bad idea because it means the notebook breaks if not run with my IBM Quantum account. This PR reorganises the page to get `job_id` programatically first. This lets us avoid hardcoding the `job_id` in the notebook, which means we can run the notebook with any IBM account that has submitted at least one job. --------- Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
This page originally submitted a simple job using the cloud simulator as a demonstration. Since the simulators are being deprecated, #1160 removed the job-submitting step and hardcoded the
job_id
into the notebook. This was a bad idea because it means the notebook breaks if not run with my IBM Quantum account.This PR reorganises the page to get
job_id
programatically first. This lets us avoid hardcoding thejob_id
in the notebook, which means we can run the notebook with any IBM account that has submitted at least one job.