Fit new notebooks into existing content #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
One or more of the the following people are requested to review this: |
kaelynj
reviewed
Apr 18, 2024
|
Good point, I've made #1194 to track that. |
javabster
reviewed
Apr 18, 2024
| } | ||
| ] | ||
| }, | ||
| { | ||
| "title": "Quantum Serverless workloads", | ||
| "url": "/run/quantum-serverless" | ||
| }, | ||
| { | ||
| "title": "Visualize results", |
There was a problem hiding this comment.
I think this should go above quantum serverless in the side bar
There was a problem hiding this comment.
How does output work for this file? It doesn't seem like it'd be deterministic when we rerun the notebook, or if a local user runs with a different account?
There was a problem hiding this comment.
The output will be deterministic when running using my account (which we also use in our actions). Users won't have access to this job but I think that's ok, plus there's no way to demonstrate retrieving a job without picking one from my account.
| @@ -32,7 +32,7 @@ | |||
| ] | |||
| NOTEBOOKS_THAT_SUBMIT_JOBS = [ | |||
| "docs/start/hello-world.ipynb", | |||
| "docs/analyze/saving-and-retrieving.ipynb", | |||
| "docs/run/save-and-retrieve.ipynb", | |||
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Fix oversight in #1160. This notebook no longer submits jobs so can be removed from the list.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
This page originally submitted a simple job using the cloud simulator as a demonstration. Since the simulators are being deprecated, #1160 removed the job-submitting step and hardcoded the `job_id` into the notebook. This was a bad idea because it means the notebook breaks if not run with my IBM Quantum account. This PR reorganises the page to get `job_id` programatically first. This lets us avoid hardcoding the `job_id` in the notebook, which means we can run the notebook with any IBM account that has submitted at least one job. --------- Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
frankharkins
added a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
PRs Qiskit#977 and Qiskit#1099 added some new pages in anticipation of a restructure which has since been postponed. This PR fits those pages into our current content structure.
frankharkins
added a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
Fix oversight in Qiskit#1160. This notebook no longer submits jobs so can be removed from the list.
frankharkins
added a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
This page originally submitted a simple job using the cloud simulator as a demonstration. Since the simulators are being deprecated, Qiskit#1160 removed the job-submitting step and hardcoded the `job_id` into the notebook. This was a bad idea because it means the notebook breaks if not run with my IBM Quantum account. This PR reorganises the page to get `job_id` programatically first. This lets us avoid hardcoding the `job_id` in the notebook, which means we can run the notebook with any IBM account that has submitted at least one job. --------- Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs #977 and #1099 added some new pages in anticipation of a restructure which has since been postponed. This PR fits those pages into our current content structure.