Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python version in CI #1210

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix Python version in CI #1210

merged 1 commit into from
Apr 19, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

Fixes #1207. We use list[str] in type hints rather than List[str], which was only added in Python 3.9. So it broke CI.

Python 3.9 is fine as a floor, given that Python 3.12 is newest.

@Eric-Arellano Eric-Arellano merged commit 1305558 into main Apr 19, 2024
2 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/fix-python-ci branch April 19, 2024 19:04
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Fixes Qiskit#1207. We use
`list[str]` in type hints rather than `List[str]`, which was only added
in Python 3.9. So it broke CI.

Python 3.9 is fine as a floor, given that Python 3.12 is newest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant