Skip to content

Conversation

@Eric-Arellano
Copy link
Collaborator

Prework for #1255. This PR only adds the generic mechanism but doesn't yet use it for Qiskit to keep the diff smaller.

Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this into more than one PR

Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

github-merge-queue bot pushed a commit that referenced this pull request Apr 30, 2024
Prework for #1256. It was
confusing how we pass both `tocModules: TocEntry[]` and
`tocModulesByTitle: Dictionary<TocEntry>`. It wasn't clear how those
values relate, and `Dictionary` is an under-documented API by Lodash.

Also adds `hasPrefix`, which we will need in
#1256.
@Eric-Arellano Eric-Arellano added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit 6497188 Apr 30, 2024
@Eric-Arellano Eric-Arellano deleted the EA/allow-grouping branch April 30, 2024 21:04
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Prework for Qiskit#1256. It was
confusing how we pass both `tocModules: TocEntry[]` and
`tocModulesByTitle: Dictionary<TocEntry>`. It wasn't clear how those
values relate, and `Dictionary` is an under-documented API by Lodash.

Also adds `hasPrefix`, which we will need in
Qiskit#1256.
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Prework for Qiskit#1255. This PR
only adds the generic mechanism but doesn't yet use it for Qiskit to
keep the diff smaller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants