-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Qiskit table of contents into sections #1255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
Prework for #1255. This PR only adds the generic mechanism but doesn't yet use it for Qiskit to keep the diff smaller.
Eric-Arellano
force-pushed
the
EA/qiskit-leftnavbar
branch
2 times, most recently
from
May 1, 2024 14:25
628595e
to
a1771a3
Compare
Eric-Arellano
changed the title
[wip] Group Qiskit table of contents into sections
Group Qiskit table of contents into sections
May 1, 2024
Eric-Arellano
force-pushed
the
EA/qiskit-leftnavbar
branch
from
May 2, 2024 18:56
a1771a3
to
f4ee5ab
Compare
Eric-Arellano
requested review from
mtreinish,
jakelishman,
javabster,
frankharkins and
arnaucasau
May 2, 2024 19:45
frankharkins
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
Prework for Qiskit#1255. This PR only adds the generic mechanism but doesn't yet use it for Qiskit to keep the diff smaller.
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
Closes Qiskit#1211. See Qiskit/qiskit#12333 for the sibling PR in Qiskit. We'll land the test Qiskit#1300 once both PRs have landed. This uses the same grouping as Qiskit#1211 (comment), if people prefer reviewing the list over code. Before: <img width="254" alt="Screenshot 2024-05-01 at 10 27 43 AM" src="https://github.com/Qiskit/documentation/assets/14852634/5b503347-accd-4847-a7e2-aedf3546fcba"> After: <img width="269" alt="Screenshot 2024-05-01 at 10 28 02 AM" src="https://github.com/Qiskit/documentation/assets/14852634/c1a358f6-26f5-4e6e-80e9-2ee440eec94f"> <img width="272" alt="Screenshot 2024-05-01 at 10 28 15 AM" src="https://github.com/Qiskit/documentation/assets/14852634/c3c80ca7-96e5-4942-ac39-6795b9504277"> This also improves historical APIs <img width="271" alt="Screenshot 2024-05-01 at 10 29 08 AM" src="https://github.com/Qiskit/documentation/assets/14852634/362cc70f-4c7e-49c4-9447-78af2a648452">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1211. See Qiskit/qiskit#12333 for the sibling PR in Qiskit. We'll land the test #1300 once both PRs have landed.
This uses the same grouping as #1211 (comment), if people prefer reviewing the list over code.
Before:
After:
This also improves historical APIs