Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize API index page into sections (backport #12333) #12381

Merged
merged 1 commit into from
May 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 9, 2024

In Qiskit/documentation#1255 (motivating issue: Qiskit/documentation#1211), we reorganize the Qiskit table of contents into logical groups. This PR changes the index page to mirror the groupings.

Screenshots

index page Screenshot 2024-05-02 at 3 43 03 PM Screenshot 2024-05-02 at 3 43 38 PM
docs ToC

image

Keeping in sync with qiskit/documentation

While we duplicate the groupings between this index page and qiskit/documentation's Sphinx -> MDX pipeline, we will add a test in qiskit/documentation after this PR lands to ensure that the two files are in sync: Qiskit/documentation#1300. Qiskit/qiskit is seen as the source of truth; qiskit/documentation will update to reflect qiskit/qiskit when changes are made.

(Given the docs architecture, it would be non-trivial to have the docs generation generate its groupings based on the index page. It's simpler to validate through a test that runs in CI.)


This is an automatic backport of pull request #12333 done by Mergify.

* Reorganize API index page into sections

* Sort alphabetically within each section

* Clarify ordering expectation

(cherry picked from commit 8c8c78a)
@mergify mergify bot requested a review from a team as a code owner May 9, 2024 19:46
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@github-actions github-actions bot added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels May 9, 2024
@github-actions github-actions bot added this to the 1.1.0 milestone May 9, 2024
@Eric-Arellano Eric-Arellano requested a review from SooluThomas May 9, 2024 19:46
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9022667421

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.647%

Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 88.38%
crates/qasm2/src/lex.rs 4 92.88%
Totals Coverage Status
Change from base Build 9022399991: 0.02%
Covered Lines: 62259
Relevant Lines: 69449

💛 - Coveralls

@mtreinish mtreinish enabled auto-merge May 9, 2024 20:14
@mtreinish mtreinish added this pull request to the merge queue May 9, 2024
Merged via the queue into stable/1.1 with commit 5ff59a8 May 9, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.1/pr-12333 branch May 9, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants