Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow not setting githubSlug #1308

Merged
merged 1 commit into from
May 7, 2024
Merged

Allow not setting githubSlug #1308

merged 1 commit into from
May 7, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

The new Qiskit transpiler service client will not have GitHub links when we first add it.

scripts/lib/api/Pkg.ts Outdated Show resolved Hide resolved
@Eric-Arellano Eric-Arellano added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit f8aaea3 May 7, 2024
2 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/no-githubSlug branch May 7, 2024 12:39
github-merge-queue bot pushed a commit that referenced this pull request May 8, 2024
Turns out, this truncation does not work well with
#1317. We agreed the best
approach is to show the full module path for that package.

This PR also fixes #1308 to
put the error in the correct location.
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
The new Qiskit transpiler service client will not have GitHub links when
we first add it.
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Turns out, this truncation does not work well with
Qiskit#1317. We agreed the best
approach is to show the full module path for that package.

This PR also fixes Qiskit#1308 to
put the error in the correct location.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants