Skip to content

Bring in pinns update for colibritd-pde tutorial #4305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 26, 2025
Merged

Bring in pinns update for colibritd-pde tutorial #4305

merged 12 commits into from
Nov 26, 2025

Conversation

@abbycross
Copy link
Collaborator

@abbycross abbycross commented Nov 24, 2025

Closes #4141

@review-notebook-app
Copy link

review-notebook-app bot commented Nov 24, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@abbycross abbycross mentioned this pull request Nov 24, 2025
Closed
@abbycross
Copy link
Collaborator Author

abbycross commented Nov 26, 2025

Hi @kbaumann1991, please check to make sure everything was captured, and that the small copyedits I made look good. Here is a staged preview of the page.

@kbaumann1991
Copy link

kbaumann1991 commented Nov 26, 2025 via email •
edited by abbycross
Loading

@abbycross abbycross requested a review from pandasa123 November 26, 2025 17:06
frankharkins
frankharkins previously approved these changes Nov 26, 2025
View reviewed changes
Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

arnaucasau
arnaucasau reviewed Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abbycross abbycross requested a review from arnaucasau November 26, 2025 19:43
arnaucasau
arnaucasau reviewed Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@arnaucasau arnaucasau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for reverting the other changes, Abby!!

abbycross
abbycross commented Nov 26, 2025
View reviewed changes
abbycross
abbycross commented Nov 26, 2025
View reviewed changes
@abbycross abbycross requested a review from arnaucasau November 26, 2025 20:03
arnaucasau
arnaucasau approved these changes Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@abbycross abbycross marked this pull request as ready for review November 26, 2025 21:32
@abbycross abbycross added this pull request to the merge queue Nov 26, 2025
@qiskit-bot
Copy link
Contributor

qiskit-bot commented Nov 26, 2025

One or more of the following people are relevant to this code:

Merged via the queue into main with commit de19e82 Nov 26, 2025
4 checks passed
@abbycross abbycross deleted the ajc/colibri-td branch November 26, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arnaucasau arnaucasau arnaucasau approved these changes

@kaelynj kaelynj Awaiting requested review from kaelynj

@pandasa123 pandasa123 Awaiting requested review from pandasa123

@frankharkins frankharkins Awaiting requested review from frankharkins

Assignees

No one assigned

Labels

None yet

Projects

Docs Planning
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

updated ColibriTD tutorial with pinns comparison

5 participants

@abbycross @kbaumann1991 @qiskit-bot @frankharkins @arnaucasau